feat: add separateReadonlyFromDisabled config option#2532
feat: add separateReadonlyFromDisabled config option#2532lucas-koehler merged 10 commits intoeclipsesource:masterfrom
Conversation
Allows independent control of readonly and enabled states. Adds READONLY/WRITABLE rule effects. Backward compatible (default: false).
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@sdirix @lucas-koehler please review - this provides the core and vue-vuetify implementation - the other renderers can be done separately |
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @kchobantonov , thanks for this contribution ❤️
The changes already look pretty good to me.
I have two points:
- The calculation
!control.enabled || control.readonlyis used in many renderers now. Could it make sense to extract a utility for this? - We should add unit tests for the following:
evalReadonly()functionhasReadonlyRule()functionisReadonly()functionisInherentlyReadonly()function- The new
separateReadonlyFromDisabledconfig option behavior inisInherentlyEnabled() - The new
READONLYandWRITABLErule effects
|
@lucas-koehler please review |
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
Thanks for the rework. Two minor comments.
|
@sdirix @lucas-koehler please review again - thanks |
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
@kchobantonov LGTM now 🚀 Thanks for the contribution and all the updates ❤️
lucas-koehler
dismissed
sdirix’s stale review
The two comments have been fixed in the latest commit :)
|
@sdirix I added this to the milestone despite having an issue because the issue does not consider the vuetify implementation |
4 participants
Allows independent control of readonly and enabled states. Adds READONLY/WRITABLE rule effects. Backward compatible (default: false).
fixes #2479